aboutsummaryrefslogtreecommitdiffstats
path: root/server
diff options
context:
space:
mode:
authorKostya <mail@sartin.in>2026-10-11 10:35:20 +0300
committerKostya <mail@sartin.in>2026-10-11 10:35:48 +0300
commit1cb67cec8951553fdb5969d947e49f2288f3847f (patch)
treed5ed5cb64692e81514484c127a9cad86161b26c6 /server
parent6f0ab9c9a20b96890ed60bc168b28d29f5db39e5 (diff)
downloadguess-market-1cb67cec8951553fdb5969d947e49f2288f3847f.tar.gz
guess-market-1cb67cec8951553fdb5969d947e49f2288f3847f.tar.xz
guess-market-1cb67cec8951553fdb5969d947e49f2288f3847f.zip
server: add event and order endpoints
Expose the market to logged-in clients: - GET /api/events lists every event, GET /api/events/{name} returns one event's details, order books, trades and participants. - POST /api/events/{name}/open and /resolve (form field "option") open and settle an event. The engine's openEvent does not know who is asking, so the servlet checks the caller is the event's Market Maker and answers 403 otherwise, for both actions. - POST /api/orders places a buy or sell order as the logged-in user, never as a name the client sends. Events are addressed by their URL-encoded name, which is their identity in v3. Request input is checked before it reaches the engine. The engine treats any side other than SELL as a buy, takes any quantity, and Event.getOption throws on an unknown key, so all of these would have turned client mistakes into wrong trades or 500 errors. Above all, settling on an unknown winning option would close the event and pay nobody. The servlets reject these as 400s. Login is checked inside each servlet through Sessions.requireUser rather than in a second filter: the order of annotation-registered filters is unspecified, and an auth filter running before CorsFilter would send 401s without CORS headers, which browsers report as network errors.
Diffstat (limited to 'server')
-rw-r--r--server/src/main/java/market/guess/server/EventsServlet.java122
-rw-r--r--server/src/main/java/market/guess/server/OrdersServlet.java75
-rw-r--r--server/src/main/java/market/guess/server/Sessions.java11
-rw-r--r--server/src/main/java/market/guess/server/UploadServlet.java3
-rw-r--r--server/src/test/java/market/guess/server/EventsTest.java145
5 files changed, 354 insertions, 2 deletions
diff --git a/server/src/main/java/market/guess/server/EventsServlet.java b/server/src/main/java/market/guess/server/EventsServlet.java
new file mode 100644
index 0000000..0697bb0
--- /dev/null
+++ b/server/src/main/java/market/guess/server/EventsServlet.java
@@ -0,0 +1,122 @@
1package market.guess.server;
2
3import jakarta.servlet.annotation.WebServlet;
4import jakarta.servlet.http.HttpServlet;
5import jakarta.servlet.http.HttpServletRequest;
6import jakarta.servlet.http.HttpServletResponse;
7import java.io.IOException;
8import market.guess.service.domain.Event;
9
10/**
11 * Events, addressed by name (URL-encoded):
12 *
13 * <ul>
14 * <li>GET /api/events: summaries of every event
15 * <li>GET /api/events/{name}: details, order books, trades, participants
16 * <li>POST /api/events/{name}/open: Market Maker opens a not-started event
17 * <li>POST /api/events/{name}/resolve, form {@code option}: Market Maker settles it
18 * </ul>
19 */
20@WebServlet(urlPatterns = {"/api/events", "/api/events/*"})
21public final class EventsServlet extends HttpServlet {
22 private static final String OPEN = "/open";
23 private static final String RESOLVE = "/resolve";
24
25 @Override
26 protected void doGet(HttpServletRequest req, HttpServletResponse res) throws IOException {
27 if (Sessions.requireUser(req, res) == null) {
28 return;
29 }
30 var engine = ServerEngine.from(getServletContext());
31 var path = req.getPathInfo();
32 if (path == null || path.equals("/")) {
33 Json.send(res, HttpServletResponse.SC_OK, engine.catalog().getAllEvents().getData());
34 return;
35 }
36
37 var event = engine.events().get(path.substring(1));
38 if (event.isEmpty()) {
39 notFound(res, path.substring(1));
40 return;
41 }
42 Json.send(
43 res,
44 HttpServletResponse.SC_OK,
45 engine.catalog().getEvent(event.get().getEventKey()).getData());
46 }
47
48 @Override
49 protected void doPost(HttpServletRequest req, HttpServletResponse res) throws IOException {
50 var user = Sessions.requireUser(req, res);
51 if (user == null) {
52 return;
53 }
54 var path = req.getPathInfo() == null ? "" : req.getPathInfo();
55 var action = path.endsWith(OPEN) ? OPEN : path.endsWith(RESOLVE) ? RESOLVE : null;
56 if (action == null || path.length() <= action.length() + 1) {
57 Json.error(
58 res,
59 HttpServletResponse.SC_NOT_FOUND,
60 "UNKNOWN_ACTION",
61 "Use POST /api/events/{name}/open or /resolve.");
62 return;
63 }
64
65 var engine = ServerEngine.from(getServletContext());
66 var name = path.substring(1, path.length() - action.length());
67 var found = engine.events().get(name);
68 if (found.isEmpty()) {
69 notFound(res, name);
70 return;
71 }
72 var event = found.get();
73 if (!user.equalsIgnoreCase(event.getMarketMaker())) {
74 Json.error(
75 res,
76 HttpServletResponse.SC_FORBIDDEN,
77 "NOT_MARKET_MAKER",
78 "Only " + event.getMarketMaker() + ", the Market Maker, can do that.");
79 return;
80 }
81
82 if (action.equals(OPEN)) {
83 var result = engine.catalog().openEvent(event.getEventKey());
84 if (!result.isSuccess()) {
85 Json.error(res, HttpServletResponse.SC_CONFLICT, "CANNOT_OPEN", result.getMessage());
86 return;
87 }
88 Json.send(res, HttpServletResponse.SC_OK, result.getData());
89 return;
90 }
91
92 var option = req.getParameter("option");
93 if (!hasOption(event, option)) {
94 Json.error(
95 res,
96 HttpServletResponse.SC_BAD_REQUEST,
97 "UNKNOWN_OPTION",
98 "Choose the winning option by its key, e.g. " + event.getEventKey() + ":0.");
99 return;
100 }
101 var result = engine.market().settleEvent(user, event.getEventKey(), option);
102 if (!result.isSuccess()) {
103 Json.error(
104 res, HttpServletResponse.SC_CONFLICT, "CANNOT_RESOLVE", "Only an active event can be resolved.");
105 return;
106 }
107 Json.send(res, HttpServletResponse.SC_OK, result.getData());
108 }
109
110 static boolean hasOption(Event event, String key) {
111 try {
112 return key != null && event.getOption(key) != null;
113 } catch (IllegalArgumentException e) {
114 return false;
115 }
116 }
117
118 private static void notFound(HttpServletResponse res, String name) throws IOException {
119 Json.error(
120 res, HttpServletResponse.SC_NOT_FOUND, "EVENT_NOT_FOUND", "No event named '" + name + "'.");
121 }
122}
diff --git a/server/src/main/java/market/guess/server/OrdersServlet.java b/server/src/main/java/market/guess/server/OrdersServlet.java
new file mode 100644
index 0000000..90ea262
--- /dev/null
+++ b/server/src/main/java/market/guess/server/OrdersServlet.java
@@ -0,0 +1,75 @@
1package market.guess.server;
2
3import jakarta.servlet.annotation.WebServlet;
4import jakarta.servlet.http.HttpServlet;
5import jakarta.servlet.http.HttpServletRequest;
6import jakarta.servlet.http.HttpServletResponse;
7import java.io.IOException;
8import java.math.BigDecimal;
9
10/**
11 * POST /api/orders, form fields {@code event} (name), {@code option} (key), {@code side} (BUY or
12 * SELL), {@code price}, {@code quantity}. Always trades as the logged-in user.
13 */
14@WebServlet("/api/orders")
15public final class OrdersServlet extends HttpServlet {
16 @Override
17 protected void doPost(HttpServletRequest req, HttpServletResponse res) throws IOException {
18 var user = Sessions.requireUser(req, res);
19 if (user == null) {
20 return;
21 }
22
23 var side = req.getParameter("side");
24 if (!"BUY".equalsIgnoreCase(side) && !"SELL".equalsIgnoreCase(side)) {
25 badRequest(res, "INVALID_SIDE", "Side must be BUY or SELL.");
26 return;
27 }
28 BigDecimal price;
29 long quantity;
30 try {
31 price = new BigDecimal(req.getParameter("price").trim());
32 quantity = Long.parseLong(req.getParameter("quantity").trim());
33 } catch (NullPointerException | NumberFormatException e) {
34 badRequest(res, "INVALID_ORDER", "Price must be a number and quantity a whole number.");
35 return;
36 }
37 if (quantity <= 0) {
38 badRequest(res, "INVALID_QUANTITY", "Quantity must be at least 1.");
39 return;
40 }
41
42 var engine = ServerEngine.from(getServletContext());
43 var event = engine.events().get(String.valueOf(req.getParameter("event")));
44 if (event.isEmpty()) {
45 Json.error(
46 res, HttpServletResponse.SC_NOT_FOUND, "EVENT_NOT_FOUND", "No such event.");
47 return;
48 }
49 if (!EventsServlet.hasOption(event.get(), req.getParameter("option"))) {
50 badRequest(res, "UNKNOWN_OPTION", "No such option in this event.");
51 return;
52 }
53
54 var result =
55 engine
56 .market()
57 .placeOrder(
58 user,
59 event.get().getEventKey(),
60 req.getParameter("option"),
61 side.toUpperCase(),
62 price,
63 quantity);
64 if (!result.isSuccess()) {
65 badRequest(res, "ORDER_REJECTED", result.getMessage());
66 return;
67 }
68 Json.send(res, HttpServletResponse.SC_OK, result.getData());
69 }
70
71 private static void badRequest(HttpServletResponse res, String code, String message)
72 throws IOException {
73 Json.error(res, HttpServletResponse.SC_BAD_REQUEST, code, message);
74 }
75}
diff --git a/server/src/main/java/market/guess/server/Sessions.java b/server/src/main/java/market/guess/server/Sessions.java
index ae9d530..7a99dfa 100644
--- a/server/src/main/java/market/guess/server/Sessions.java
+++ b/server/src/main/java/market/guess/server/Sessions.java
@@ -1,7 +1,9 @@
1package market.guess.server; 1package market.guess.server;
2 2
3import jakarta.servlet.http.HttpServletRequest; 3import jakarta.servlet.http.HttpServletRequest;
4import jakarta.servlet.http.HttpServletResponse;
4import jakarta.servlet.http.HttpSession; 5import jakarta.servlet.http.HttpSession;
6import java.io.IOException;
5import java.util.Map; 7import java.util.Map;
6import java.util.concurrent.ConcurrentHashMap; 8import java.util.concurrent.ConcurrentHashMap;
7import market.guess.api.Result; 9import market.guess.api.Result;
@@ -53,6 +55,15 @@ public final class Sessions {
53 } 55 }
54 } 56 }
55 57
58 public static String requireUser(HttpServletRequest req, HttpServletResponse res)
59 throws IOException {
60 var user = currentUser(req);
61 if (user == null) {
62 Json.error(res, HttpServletResponse.SC_UNAUTHORIZED, "NOT_LOGGED_IN", "Please log in first.");
63 }
64 return user;
65 }
66
56 public static String currentUser(HttpServletRequest req) { 67 public static String currentUser(HttpServletRequest req) {
57 var session = req.getSession(false); 68 var session = req.getSession(false);
58 return session == null ? null : (String) session.getAttribute(USER); 69 return session == null ? null : (String) session.getAttribute(USER);
diff --git a/server/src/main/java/market/guess/server/UploadServlet.java b/server/src/main/java/market/guess/server/UploadServlet.java
index 5fe69ad..c3d5a73 100644
--- a/server/src/main/java/market/guess/server/UploadServlet.java
+++ b/server/src/main/java/market/guess/server/UploadServlet.java
@@ -27,9 +27,8 @@ public final class UploadServlet extends HttpServlet {
27 27
28 @Override 28 @Override
29 protected void doPost(HttpServletRequest req, HttpServletResponse res) throws IOException { 29 protected void doPost(HttpServletRequest req, HttpServletResponse res) throws IOException {
30 var user = Sessions.currentUser(req); 30 var user = Sessions.requireUser(req, res);
31 if (user == null) { 31 if (user == null) {
32 Json.error(res, HttpServletResponse.SC_UNAUTHORIZED, "NOT_LOGGED_IN", "Please log in first.");
33 return; 32 return;
34 } 33 }
35 34
diff --git a/server/src/test/java/market/guess/server/EventsTest.java b/server/src/test/java/market/guess/server/EventsTest.java
new file mode 100644
index 0000000..b21d438
--- /dev/null
+++ b/server/src/test/java/market/guess/server/EventsTest.java
@@ -0,0 +1,145 @@
1package market.guess.server;
2
3import static org.junit.jupiter.api.Assertions.assertEquals;
4import static org.junit.jupiter.api.Assertions.assertTrue;
5
6import java.net.URLEncoder;
7import java.net.http.HttpClient;
8import java.net.http.HttpRequest;
9import java.net.http.HttpResponse;
10import java.nio.charset.StandardCharsets;
11import java.nio.file.Files;
12import java.nio.file.Path;
13import org.junit.jupiter.api.AfterAll;
14import org.junit.jupiter.api.BeforeAll;
15import org.junit.jupiter.api.Test;
16import org.junit.jupiter.api.io.TempDir;
17
18class EventsTest {
19 @TempDir static Path base;
20 static TestServer server;
21 static HttpClient mm;
22 static HttpClient trader;
23
24 @BeforeAll
25 static void start() throws Exception {
26 server = new TestServer(base);
27 mm = loggedIn(server, "Maya");
28 trader = loggedIn(server, "Tom");
29 assertEquals(200, upload(server, mm, "multiple.xml").statusCode());
30 }
31
32 @AfterAll
33 static void stop() throws Exception {
34 server.close();
35 }
36
37 static HttpClient loggedIn(TestServer server, String name) throws Exception {
38 var client = TestServer.client();
39 assertEquals(200, server.post(client, "/login", "username", name).statusCode());
40 return client;
41 }
42
43 static HttpResponse<String> upload(TestServer server, HttpClient client, String sample)
44 throws Exception {
45 var boundary = "gm-test-boundary";
46 var head =
47 "--"
48 + boundary
49 + "\r\nContent-Disposition: form-data; name=\"file\"; filename=\""
50 + sample
51 + "\"\r\n\r\n";
52 var body =
53 head
54 + Files.readString(Path.of("test-data/ex-3", sample))
55 + "\r\n--"
56 + boundary
57 + "--\r\n";
58 var req =
59 server
60 .request("/upload")
61 .header("Content-Type", "multipart/form-data; boundary=" + boundary)
62 .POST(HttpRequest.BodyPublishers.ofString(body))
63 .build();
64 return client.send(req, HttpResponse.BodyHandlers.ofString());
65 }
66
67 static String path(String eventName) {
68 return "/events/" + URLEncoder.encode(eventName, StandardCharsets.UTF_8).replace("+", "%20");
69 }
70
71 @Test
72 void listsAndDetailsEventsByName() throws Exception {
73 var list = server.get(trader, "/events");
74 assertEquals(200, list.statusCode());
75 assertTrue(list.body().contains("\"name\":\"World Cap Winner\""), list.body());
76 assertTrue(list.body().contains("\"marketMaker\":\"Maya\""), list.body());
77
78 var detail = server.get(trader, path("Will it rain tomorrow ?"));
79 assertEquals(200, detail.statusCode(), detail.body());
80 assertTrue(detail.body().contains("\"status\":\"DRAFT\""), detail.body());
81
82 assertEquals(404, server.get(trader, path("No Such Event")).statusCode());
83 assertEquals(401, server.get(TestServer.client(), "/events").statusCode());
84 }
85
86 @Test
87 void onlyTheMarketMakerOpensAndResolves() throws Exception {
88 var cup = path("World Cap Winner");
89 var notMm = server.post(trader, cup + "/open");
90 assertEquals(403, notMm.statusCode());
91 assertTrue(notMm.body().contains("NOT_MARKET_MAKER"), notMm.body());
92 assertEquals(403, server.post(trader, cup + "/resolve", "option", "World Cap Winner:0").statusCode());
93
94 var broke = server.post(mm, cup + "/open");
95 assertEquals(409, broke.statusCode());
96 assertTrue(broke.body().contains("CANNOT_OPEN"), broke.body());
97
98 var notActive = server.post(mm, cup + "/resolve", "option", "World Cap Winner:0");
99 assertEquals(409, notActive.statusCode());
100
101 var unknownWinner = server.post(mm, cup + "/resolve", "option", "World Cap Winner:7");
102 assertEquals(400, unknownWinner.statusCode());
103 assertTrue(unknownWinner.body().contains("UNKNOWN_OPTION"), unknownWinner.body());
104
105 assertEquals(404, server.post(mm, cup + "/close").statusCode());
106 }
107
108 @Test
109 void rejectsMalformedOrders() throws Exception {
110 var event = "World Cap Winner";
111 var option = "World Cap Winner:0";
112 assertEquals(
113 400,
114 server
115 .post(trader, "/orders", "event", event, "option", option, "side", "HOLD", "price", "0.5", "quantity", "1")
116 .statusCode());
117 assertEquals(
118 400,
119 server
120 .post(trader, "/orders", "event", event, "option", option, "side", "BUY", "price", "x", "quantity", "1")
121 .statusCode());
122 assertEquals(
123 400,
124 server
125 .post(trader, "/orders", "event", event, "option", option, "side", "BUY", "price", "0.5", "quantity", "0")
126 .statusCode());
127 assertEquals(
128 404,
129 server
130 .post(trader, "/orders", "event", "Nope", "option", option, "side", "BUY", "price", "0.5", "quantity", "1")
131 .statusCode());
132
133 var badOption =
134 server.post(
135 trader, "/orders", "event", event, "option", "Brazil", "side", "BUY", "price", "0.5", "quantity", "1");
136 assertEquals(400, badOption.statusCode());
137 assertTrue(badOption.body().contains("UNKNOWN_OPTION"), badOption.body());
138
139 var notOpen =
140 server.post(
141 trader, "/orders", "event", event, "option", option, "side", "BUY", "price", "0.5", "quantity", "1");
142 assertEquals(400, notOpen.statusCode());
143 assertTrue(notOpen.body().contains("ORDER_REJECTED"), notOpen.body());
144 }
145}