diff options
| author | Kostya <mail@sartin.in> | 2026-10-08 16:45:02 +0300 |
|---|---|---|
| committer | Kostya <mail@sartin.in> | 2026-10-08 16:45:30 +0300 |
| commit | 95eb4ff500defc4e34d043bbc096593ffcadecea (patch) | |
| tree | 65630fe3cb61260a5fedf7f63d969d27ccdb430b /service/src/test/java/market/guess | |
| parent | 930eb953e8cb598a99002cb41f3b8f57d05f1fa7 (diff) | |
| download | guess-market-95eb4ff500defc4e34d043bbc096593ffcadecea.tar.gz guess-market-95eb4ff500defc4e34d043bbc096593ffcadecea.tar.xz guess-market-95eb4ff500defc4e34d043bbc096593ffcadecea.zip | |
catalog: add cumulative v3 XML loader and event mapper
Exercise 3 uploads arrive over HTTP and must never be written to the
server's disk, so load Schema v3 straight from an InputStream. Each
valid file is appended to the market rather than replacing it, and the
uploading user becomes the Market Maker of every event in it.
With no id in v3, the mapper keys events by their trimmed name, so the
repository's case-insensitive lookup finds them by name. Display ids
continue from the current market size.
The whole file is validated and mapped before anything is added, so a
rejected upload leaves the market as it was. Loading is synchronized
so two concurrent uploads cannot both pass the name-collision check.
DTDs and external entities are disabled on the parser, since the input
is untrusted and an XXE payload could otherwise read server files.
Check the loader against the course's Exercise 3 sample files, kept
with their schema under test-data/ex-3/.
Diffstat (limited to 'service/src/test/java/market/guess')
| -rw-r--r-- | service/src/test/java/market/guess/service/Ex3LoaderTest.java | 102 |
1 files changed, 102 insertions, 0 deletions
diff --git a/service/src/test/java/market/guess/service/Ex3LoaderTest.java b/service/src/test/java/market/guess/service/Ex3LoaderTest.java new file mode 100644 index 0000000..745b1fd --- /dev/null +++ b/service/src/test/java/market/guess/service/Ex3LoaderTest.java | |||
| @@ -0,0 +1,102 @@ | |||
| 1 | package market.guess.service; | ||
| 2 | |||
| 3 | import static market.guess.service.Ex3ValidatorTest.lmsr; | ||
| 4 | import static market.guess.service.Ex3ValidatorTest.market; | ||
| 5 | import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| 6 | import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| 7 | import static org.junit.jupiter.api.Assertions.assertTrue; | ||
| 8 | |||
| 9 | import java.io.ByteArrayInputStream; | ||
| 10 | import java.io.InputStream; | ||
| 11 | import java.nio.charset.StandardCharsets; | ||
| 12 | import java.nio.file.Files; | ||
| 13 | import java.nio.file.Path; | ||
| 14 | import market.guess.model.event.EventStatus; | ||
| 15 | import market.guess.service.catalog.infrastructure.mapper.v3.EventMapperV3; | ||
| 16 | import market.guess.service.catalog.infrastructure.provider.v3.XMLLoaderV3; | ||
| 17 | import market.guess.service.catalog.infrastructure.provider.v3.XMLValidatorV3; | ||
| 18 | import market.guess.service.catalog.infrastructure.repository.InMemoryEventRepository; | ||
| 19 | import org.junit.jupiter.api.BeforeEach; | ||
| 20 | import org.junit.jupiter.api.Test; | ||
| 21 | |||
| 22 | class Ex3LoaderTest { | ||
| 23 | private InMemoryEventRepository eventRepo; | ||
| 24 | private XMLLoaderV3 loader; | ||
| 25 | |||
| 26 | @BeforeEach | ||
| 27 | void setUp() { | ||
| 28 | eventRepo = new InMemoryEventRepository(); | ||
| 29 | loader = new XMLLoaderV3(eventRepo, new EventMapperV3(), new XMLValidatorV3()); | ||
| 30 | } | ||
| 31 | |||
| 32 | private static InputStream stream(String xml) { | ||
| 33 | return new ByteArrayInputStream(xml.getBytes(StandardCharsets.UTF_8)); | ||
| 34 | } | ||
| 35 | |||
| 36 | @Test | ||
| 37 | void uploadsAccumulateAndUploaderBecomesMarketMaker() { | ||
| 38 | var first = loader.load(stream(market(lmsr("Rain"), lmsr("Snow"))), "a.xml", "alice"); | ||
| 39 | assertTrue(first.isSuccess(), first.getDetails()); | ||
| 40 | assertEquals(2, first.getData().eventsLoaded()); | ||
| 41 | |||
| 42 | var second = loader.load(stream(market(lmsr("Hail"))), "b.xml", "bob"); | ||
| 43 | assertTrue(second.isSuccess(), second.getDetails()); | ||
| 44 | assertEquals(3, eventRepo.getAll().size()); | ||
| 45 | |||
| 46 | var rain = eventRepo.get("rain").orElseThrow(); | ||
| 47 | assertEquals("Rain", rain.getName()); | ||
| 48 | assertEquals("alice", rain.getMarketMaker()); | ||
| 49 | assertEquals(EventStatus.DRAFT, rain.getState()); | ||
| 50 | assertEquals("bob", eventRepo.get("Hail").orElseThrow().getMarketMaker()); | ||
| 51 | } | ||
| 52 | |||
| 53 | @Test | ||
| 54 | void loadsCourseSampleFilesCumulatively() throws Exception { | ||
| 55 | try (var small = Files.newInputStream(Path.of("test-data/ex-3/small.xml")); | ||
| 56 | var multiple = Files.newInputStream(Path.of("test-data/ex-3/multiple.xml"))) { | ||
| 57 | var first = loader.load(small, "small.xml", "alice"); | ||
| 58 | assertTrue(first.isSuccess(), first.getDetails()); | ||
| 59 | var second = loader.load(multiple, "multiple.xml", "bob"); | ||
| 60 | assertTrue(second.isSuccess(), second.getDetails()); | ||
| 61 | assertEquals(3, second.getData().eventsLoaded()); | ||
| 62 | } | ||
| 63 | assertEquals(4, eventRepo.getAll().size()); | ||
| 64 | assertEquals("alice", eventRepo.get("Mujtaba is Dead").orElseThrow().getMarketMaker()); | ||
| 65 | assertEquals("bob", eventRepo.get("World Cap Winner").orElseThrow().getMarketMaker()); | ||
| 66 | |||
| 67 | try (var again = Files.newInputStream(Path.of("test-data/ex-3/small.xml"))) { | ||
| 68 | assertEquals("NAME_TAKEN", loader.load(again, "small.xml", "carol").getMessage()); | ||
| 69 | } | ||
| 70 | assertEquals(4, eventRepo.getAll().size()); | ||
| 71 | } | ||
| 72 | |||
| 73 | @Test | ||
| 74 | void collisionRejectsWholeFileAndKeepsMarket() { | ||
| 75 | loader.load(stream(market(lmsr("Rain"))), "a.xml", "alice"); | ||
| 76 | |||
| 77 | var res = loader.load(stream(market(lmsr("Fog"), lmsr("rain"))), "b.xml", "bob"); | ||
| 78 | assertFalse(res.isSuccess()); | ||
| 79 | assertEquals("NAME_TAKEN", res.getMessage()); | ||
| 80 | assertEquals(1, eventRepo.getAll().size()); | ||
| 81 | assertTrue(eventRepo.get("Fog").isEmpty()); | ||
| 82 | } | ||
| 83 | |||
| 84 | @Test | ||
| 85 | void rejectsMalformedXmlAndMissingUploader() { | ||
| 86 | assertEquals( | ||
| 87 | "XML_PARSE_ERROR", loader.load(stream("<Guess-Market>"), "x.xml", "alice").getMessage()); | ||
| 88 | assertEquals( | ||
| 89 | "INVALID_UPLOADER", loader.load(stream(market(lmsr("Rain"))), "x.xml", " ").getMessage()); | ||
| 90 | assertTrue(eventRepo.getAll().isEmpty()); | ||
| 91 | } | ||
| 92 | |||
| 93 | @Test | ||
| 94 | void refusesDtdsSoExternalEntitiesCannotBeRead() { | ||
| 95 | var xxe = | ||
| 96 | "<?xml version=\"1.0\"?><!DOCTYPE Guess-Market [<!ENTITY x SYSTEM \"file:///etc/passwd\">]>" | ||
| 97 | + market(lmsr("&x;")); | ||
| 98 | var res = loader.load(stream(xxe), "x.xml", "alice"); | ||
| 99 | assertEquals("XML_PARSE_ERROR", res.getMessage()); | ||
| 100 | assertTrue(eventRepo.getAll().isEmpty()); | ||
| 101 | } | ||
| 102 | } | ||