From 241fd5f0a46aff89a3302d2753a01e217a562e79 Mon Sep 17 00:00:00 2001 From: Kostya Date: Sun, 11 Oct 2026 14:48:12 +0300 Subject: server: serialize engine access with one read/write lock The engine was written for a single-threaded desktop app: users, events and ledgers live in plain lists, and a balance update is a read followed by a write. Tomcat runs each request on its own thread, so once clients poll while others trade, a read can iterate a list mid-insert and fail with a 500, and two deposits can both read the same old balance and lose one update. Every server-side call into the engine arrives through /api/*, so put one ReentrantReadWriteLock in a filter there. GETs, which is all the polling, share the read lock and still run in parallel. Everything else takes the write lock and changes the market alone, which also makes check-then-act steps like opening an event or claiming a username atomic. Writes are short in-memory operations, so one lock is enough. Per-event locks are the next step if trading volume ever needs them. The test runs writers depositing into one account while others poll three endpoints and log new users in. Without the filter it fails with 500s; with it, every request succeeds and the balance and ledger count match the number of deposits. --- .../java/market/guess/server/EngineLockFilter.java | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 server/src/main/java/market/guess/server/EngineLockFilter.java (limited to 'server/src/main/java') diff --git a/server/src/main/java/market/guess/server/EngineLockFilter.java b/server/src/main/java/market/guess/server/EngineLockFilter.java new file mode 100644 index 0000000..181d96b --- /dev/null +++ b/server/src/main/java/market/guess/server/EngineLockFilter.java @@ -0,0 +1,27 @@ +package market.guess.server; + +import jakarta.servlet.FilterChain; +import jakarta.servlet.ServletException; +import jakarta.servlet.annotation.WebFilter; +import jakarta.servlet.http.HttpFilter; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import java.io.IOException; +import java.util.concurrent.locks.ReentrantReadWriteLock; + +@WebFilter("/api/*") +public final class EngineLockFilter extends HttpFilter { + private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); + + @Override + protected void doFilter(HttpServletRequest req, HttpServletResponse res, FilterChain chain) + throws IOException, ServletException { + var held = "GET".equals(req.getMethod()) ? lock.readLock() : lock.writeLock(); + held.lock(); + try { + chain.doFilter(req, res); + } finally { + held.unlock(); + } + } +} -- cgit v1.2.3