From 4563c9d6d6c1576b6fb45899c2b6d6073966d8b8 Mon Sep 17 00:00:00 2001 From: Kostya Date: Thu, 15 Oct 2026 11:40:05 +0300 Subject: server: add a chat shared by everyone logged in Ex3 bonus. POST /api/chat says a line as the logged-in user and GET /api/chat?since=N returns the lines after id N, so a polling client only ever downloads what it has not seen. The last 500 lines are kept in memory. A chat line does not change the market, so the lock filter does not bump the market version for it; otherwise every line would make every client refetch all events. Also read form fields as UTF-8 in the filter rather than relying on Tomcat's default, since names and chat text may not be ASCII. --- .../main/java/market/guess/server/ChatRoom.java | 36 +++++++++++++++ .../main/java/market/guess/server/ChatServlet.java | 53 ++++++++++++++++++++++ .../java/market/guess/server/EngineLockFilter.java | 5 +- .../java/market/guess/server/ServerEngine.java | 6 +++ 4 files changed, 99 insertions(+), 1 deletion(-) create mode 100644 server/src/main/java/market/guess/server/ChatRoom.java create mode 100644 server/src/main/java/market/guess/server/ChatServlet.java (limited to 'server/src/main/java') diff --git a/server/src/main/java/market/guess/server/ChatRoom.java b/server/src/main/java/market/guess/server/ChatRoom.java new file mode 100644 index 0000000..e9c8777 --- /dev/null +++ b/server/src/main/java/market/guess/server/ChatRoom.java @@ -0,0 +1,36 @@ +package market.guess.server; + +import java.time.Clock; +import java.time.LocalDateTime; +import java.time.ZoneId; +import java.time.format.DateTimeFormatter; +import java.util.ArrayList; +import java.util.List; +import market.guess.model.chat.ChatMessageDTO; + +public final class ChatRoom { + private static final int KEEP = 500; + private static final DateTimeFormatter TIME = DateTimeFormatter.ofPattern("HH:mm:ss"); + + private final Clock clock; + private final List messages = new ArrayList<>(); + private long nextId = 1; + + public ChatRoom(Clock clock) { + this.clock = clock; + } + + public synchronized ChatMessageDTO say(String sender, String text) { + var at = LocalDateTime.now(clock.withZone(ZoneId.systemDefault())).format(TIME); + var message = new ChatMessageDTO(nextId++, at, sender, text); + messages.add(message); + if (messages.size() > KEEP) { + messages.remove(0); + } + return message; + } + + public synchronized List since(long id) { + return messages.stream().filter(m -> m.id() > id).toList(); + } +} diff --git a/server/src/main/java/market/guess/server/ChatServlet.java b/server/src/main/java/market/guess/server/ChatServlet.java new file mode 100644 index 0000000..242b075 --- /dev/null +++ b/server/src/main/java/market/guess/server/ChatServlet.java @@ -0,0 +1,53 @@ +package market.guess.server; + +import jakarta.servlet.annotation.WebServlet; +import jakarta.servlet.http.HttpServlet; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import java.io.IOException; + +@WebServlet("/api/chat") +public final class ChatServlet extends HttpServlet { + static final int MAX_LENGTH = 500; + + @Override + protected void doGet(HttpServletRequest req, HttpServletResponse res) throws IOException { + if (Sessions.requireUser(req, res) == null) { + return; + } + long since; + try { + since = req.getParameter("since") == null ? 0 : Long.parseLong(req.getParameter("since")); + } catch (NumberFormatException e) { + Json.error(res, HttpServletResponse.SC_BAD_REQUEST, "INVALID_SINCE", "since must be a number."); + return; + } + Json.send( + res, HttpServletResponse.SC_OK, ServerEngine.from(getServletContext()).chat().since(since)); + } + + @Override + protected void doPost(HttpServletRequest req, HttpServletResponse res) throws IOException { + var user = Sessions.requireUser(req, res); + if (user == null) { + return; + } + var text = req.getParameter("text"); + if (text == null || text.isBlank()) { + Json.error(res, HttpServletResponse.SC_BAD_REQUEST, "EMPTY_MESSAGE", "Type a message first."); + return; + } + if (text.length() > MAX_LENGTH) { + Json.error( + res, + HttpServletResponse.SC_BAD_REQUEST, + "MESSAGE_TOO_LONG", + "A message can be at most " + MAX_LENGTH + " characters."); + return; + } + Json.send( + res, + HttpServletResponse.SC_OK, + ServerEngine.from(getServletContext()).chat().say(user, text.trim())); + } +} diff --git a/server/src/main/java/market/guess/server/EngineLockFilter.java b/server/src/main/java/market/guess/server/EngineLockFilter.java index db2b580..ca10abb 100644 --- a/server/src/main/java/market/guess/server/EngineLockFilter.java +++ b/server/src/main/java/market/guess/server/EngineLockFilter.java @@ -16,13 +16,16 @@ public final class EngineLockFilter extends HttpFilter { @Override protected void doFilter(HttpServletRequest req, HttpServletResponse res, FilterChain chain) throws IOException, ServletException { + if (req.getCharacterEncoding() == null) { + req.setCharacterEncoding("UTF-8"); + } var method = req.getMethod(); var write = !"GET".equals(method) && !"HEAD".equals(method) && !"OPTIONS".equals(method); var held = write ? lock.writeLock() : lock.readLock(); held.lock(); try { chain.doFilter(req, res); - if (write) { + if (write && !"/api/chat".equals(req.getServletPath())) { ServerEngine.from(getServletContext()).changed(); } } finally { diff --git a/server/src/main/java/market/guess/server/ServerEngine.java b/server/src/main/java/market/guess/server/ServerEngine.java index 13891a1..0160c86 100644 --- a/server/src/main/java/market/guess/server/ServerEngine.java +++ b/server/src/main/java/market/guess/server/ServerEngine.java @@ -34,6 +34,7 @@ public final class ServerEngine { private final AccountContext accounts; private final GuessMarketContext market; private final Sessions sessions; + private final ChatRoom chat; private final AtomicLong version = new AtomicLong(); public ServerEngine(Clock clock) { @@ -44,6 +45,7 @@ public final class ServerEngine { this.catalog = new LocalCatalogContext(uploads, marketInfra, events); this.accounts = new LocalAccountContext(users, ledger); this.sessions = new Sessions(users); + this.chat = new ChatRoom(clock); this.market = new LocalGuessMarketContext( marketInfra, @@ -89,6 +91,10 @@ public final class ServerEngine { return sessions; } + public ChatRoom chat() { + return chat; + } + public long version() { return version.get(); } -- cgit v1.2.3