From 1cb67cec8951553fdb5969d947e49f2288f3847f Mon Sep 17 00:00:00 2001 From: Kostya Date: Sun, 11 Oct 2026 10:35:20 +0300 Subject: server: add event and order endpoints Expose the market to logged-in clients: - GET /api/events lists every event, GET /api/events/{name} returns one event's details, order books, trades and participants. - POST /api/events/{name}/open and /resolve (form field "option") open and settle an event. The engine's openEvent does not know who is asking, so the servlet checks the caller is the event's Market Maker and answers 403 otherwise, for both actions. - POST /api/orders places a buy or sell order as the logged-in user, never as a name the client sends. Events are addressed by their URL-encoded name, which is their identity in v3. Request input is checked before it reaches the engine. The engine treats any side other than SELL as a buy, takes any quantity, and Event.getOption throws on an unknown key, so all of these would have turned client mistakes into wrong trades or 500 errors. Above all, settling on an unknown winning option would close the event and pay nobody. The servlets reject these as 400s. Login is checked inside each servlet through Sessions.requireUser rather than in a second filter: the order of annotation-registered filters is unspecified, and an auth filter running before CorsFilter would send 401s without CORS headers, which browsers report as network errors. --- .../test/java/market/guess/server/EventsTest.java | 145 +++++++++++++++++++++ 1 file changed, 145 insertions(+) create mode 100644 server/src/test/java/market/guess/server/EventsTest.java (limited to 'server/src/test/java/market') diff --git a/server/src/test/java/market/guess/server/EventsTest.java b/server/src/test/java/market/guess/server/EventsTest.java new file mode 100644 index 0000000..b21d438 --- /dev/null +++ b/server/src/test/java/market/guess/server/EventsTest.java @@ -0,0 +1,145 @@ +package market.guess.server; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.net.URLEncoder; +import java.net.http.HttpClient; +import java.net.http.HttpRequest; +import java.net.http.HttpResponse; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Path; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; + +class EventsTest { + @TempDir static Path base; + static TestServer server; + static HttpClient mm; + static HttpClient trader; + + @BeforeAll + static void start() throws Exception { + server = new TestServer(base); + mm = loggedIn(server, "Maya"); + trader = loggedIn(server, "Tom"); + assertEquals(200, upload(server, mm, "multiple.xml").statusCode()); + } + + @AfterAll + static void stop() throws Exception { + server.close(); + } + + static HttpClient loggedIn(TestServer server, String name) throws Exception { + var client = TestServer.client(); + assertEquals(200, server.post(client, "/login", "username", name).statusCode()); + return client; + } + + static HttpResponse upload(TestServer server, HttpClient client, String sample) + throws Exception { + var boundary = "gm-test-boundary"; + var head = + "--" + + boundary + + "\r\nContent-Disposition: form-data; name=\"file\"; filename=\"" + + sample + + "\"\r\n\r\n"; + var body = + head + + Files.readString(Path.of("test-data/ex-3", sample)) + + "\r\n--" + + boundary + + "--\r\n"; + var req = + server + .request("/upload") + .header("Content-Type", "multipart/form-data; boundary=" + boundary) + .POST(HttpRequest.BodyPublishers.ofString(body)) + .build(); + return client.send(req, HttpResponse.BodyHandlers.ofString()); + } + + static String path(String eventName) { + return "/events/" + URLEncoder.encode(eventName, StandardCharsets.UTF_8).replace("+", "%20"); + } + + @Test + void listsAndDetailsEventsByName() throws Exception { + var list = server.get(trader, "/events"); + assertEquals(200, list.statusCode()); + assertTrue(list.body().contains("\"name\":\"World Cap Winner\""), list.body()); + assertTrue(list.body().contains("\"marketMaker\":\"Maya\""), list.body()); + + var detail = server.get(trader, path("Will it rain tomorrow ?")); + assertEquals(200, detail.statusCode(), detail.body()); + assertTrue(detail.body().contains("\"status\":\"DRAFT\""), detail.body()); + + assertEquals(404, server.get(trader, path("No Such Event")).statusCode()); + assertEquals(401, server.get(TestServer.client(), "/events").statusCode()); + } + + @Test + void onlyTheMarketMakerOpensAndResolves() throws Exception { + var cup = path("World Cap Winner"); + var notMm = server.post(trader, cup + "/open"); + assertEquals(403, notMm.statusCode()); + assertTrue(notMm.body().contains("NOT_MARKET_MAKER"), notMm.body()); + assertEquals(403, server.post(trader, cup + "/resolve", "option", "World Cap Winner:0").statusCode()); + + var broke = server.post(mm, cup + "/open"); + assertEquals(409, broke.statusCode()); + assertTrue(broke.body().contains("CANNOT_OPEN"), broke.body()); + + var notActive = server.post(mm, cup + "/resolve", "option", "World Cap Winner:0"); + assertEquals(409, notActive.statusCode()); + + var unknownWinner = server.post(mm, cup + "/resolve", "option", "World Cap Winner:7"); + assertEquals(400, unknownWinner.statusCode()); + assertTrue(unknownWinner.body().contains("UNKNOWN_OPTION"), unknownWinner.body()); + + assertEquals(404, server.post(mm, cup + "/close").statusCode()); + } + + @Test + void rejectsMalformedOrders() throws Exception { + var event = "World Cap Winner"; + var option = "World Cap Winner:0"; + assertEquals( + 400, + server + .post(trader, "/orders", "event", event, "option", option, "side", "HOLD", "price", "0.5", "quantity", "1") + .statusCode()); + assertEquals( + 400, + server + .post(trader, "/orders", "event", event, "option", option, "side", "BUY", "price", "x", "quantity", "1") + .statusCode()); + assertEquals( + 400, + server + .post(trader, "/orders", "event", event, "option", option, "side", "BUY", "price", "0.5", "quantity", "0") + .statusCode()); + assertEquals( + 404, + server + .post(trader, "/orders", "event", "Nope", "option", option, "side", "BUY", "price", "0.5", "quantity", "1") + .statusCode()); + + var badOption = + server.post( + trader, "/orders", "event", event, "option", "Brazil", "side", "BUY", "price", "0.5", "quantity", "1"); + assertEquals(400, badOption.statusCode()); + assertTrue(badOption.body().contains("UNKNOWN_OPTION"), badOption.body()); + + var notOpen = + server.post( + trader, "/orders", "event", event, "option", option, "side", "BUY", "price", "0.5", "quantity", "1"); + assertEquals(400, notOpen.statusCode()); + assertTrue(notOpen.body().contains("ORDER_REJECTED"), notOpen.body()); + } +} -- cgit v1.2.3