From 95eb4ff500defc4e34d043bbc096593ffcadecea Mon Sep 17 00:00:00 2001 From: Kostya Date: Thu, 8 Oct 2026 16:45:02 +0300 Subject: catalog: add cumulative v3 XML loader and event mapper Exercise 3 uploads arrive over HTTP and must never be written to the server's disk, so load Schema v3 straight from an InputStream. Each valid file is appended to the market rather than replacing it, and the uploading user becomes the Market Maker of every event in it. With no id in v3, the mapper keys events by their trimmed name, so the repository's case-insensitive lookup finds them by name. Display ids continue from the current market size. The whole file is validated and mapped before anything is added, so a rejected upload leaves the market as it was. Loading is synchronized so two concurrent uploads cannot both pass the name-collision check. DTDs and external entities are disabled on the parser, since the input is untrusted and an XXE payload could otherwise read server files. Check the loader against the course's Exercise 3 sample files, kept with their schema under test-data/ex-3/. --- .../infrastructure/mapper/v3/EventMapperV3.java | 62 +++++++++++++++++ .../infrastructure/provider/v3/XMLLoaderV3.java | 78 ++++++++++++++++++++++ 2 files changed, 140 insertions(+) create mode 100644 service/src/main/java/market/guess/service/catalog/infrastructure/mapper/v3/EventMapperV3.java create mode 100644 service/src/main/java/market/guess/service/catalog/infrastructure/provider/v3/XMLLoaderV3.java (limited to 'service/src/main') diff --git a/service/src/main/java/market/guess/service/catalog/infrastructure/mapper/v3/EventMapperV3.java b/service/src/main/java/market/guess/service/catalog/infrastructure/mapper/v3/EventMapperV3.java new file mode 100644 index 0000000..7fd8112 --- /dev/null +++ b/service/src/main/java/market/guess/service/catalog/infrastructure/mapper/v3/EventMapperV3.java @@ -0,0 +1,62 @@ +package market.guess.service.catalog.infrastructure.mapper.v3; + +import java.util.ArrayList; +import java.util.List; +import market.guess.model.event.CommissionTiming; +import market.guess.model.event.EventStatus; +import market.guess.service.catalog.model.v3.GMEvent; +import market.guess.service.catalog.model.v3.GMLMSR; +import market.guess.service.catalog.model.v3.GMOrderBook; +import market.guess.service.domain.Event; +import market.guess.service.domain.Market; +import market.guess.service.mechanism.LmsrTradingMechanism; +import market.guess.service.mechanism.OrderBookTradingMechanism; +import market.guess.service.mechanism.TradingMechanism; + +public final class EventMapperV3 { + + public Event toDomain(GMEvent source, int displayId, String marketMaker) { + var key = source.getName().trim(); + return new Event( + key, + displayId, + key, + source.getDescription(), + source.getCommission().getValue(), + getTiming(source.getCommission().getType()), + getMechanism(source, source.getGMOptions().getGMOption().size()), + EventStatus.DRAFT, + getOptions(key, source.getGMOptions().getGMOption()), + marketMaker); + } + + private static CommissionTiming getTiming(String type) { + return switch (type.toLowerCase().trim()) { + case "on-close" -> CommissionTiming.ON_CLOSE; + case "on-purchase" -> CommissionTiming.ON_PURCHASE; + default -> throw new IllegalArgumentException("Unknown commission type: " + type); + }; + } + + private static TradingMechanism getMechanism(GMEvent source, int optionCount) { + if (source.getGMMethod().getGMLMSR() instanceof GMLMSR lmsr) { + return new LmsrTradingMechanism(lmsr.getB(), optionCount); + } + if (source.getGMMethod().getGMOrderBook() instanceof GMOrderBook orderBook) { + return new OrderBookTradingMechanism( + "true".equalsIgnoreCase(orderBook.getAllowMint()), + orderBook.getInitial(), + orderBook.getD(), + optionCount); + } + throw new IllegalArgumentException("Unknown trading method for event: " + source.getName()); + } + + private static List getOptions(String key, List raw) { + var ret = new ArrayList(raw.size()); + for (var i = 0; i < raw.size(); i++) { + ret.add(new Market(key + ":" + i, raw.get(i).trim())); + } + return ret; + } +} diff --git a/service/src/main/java/market/guess/service/catalog/infrastructure/provider/v3/XMLLoaderV3.java b/service/src/main/java/market/guess/service/catalog/infrastructure/provider/v3/XMLLoaderV3.java new file mode 100644 index 0000000..59aa3ad --- /dev/null +++ b/service/src/main/java/market/guess/service/catalog/infrastructure/provider/v3/XMLLoaderV3.java @@ -0,0 +1,78 @@ +package market.guess.service.catalog.infrastructure.provider.v3; + +import jakarta.xml.bind.JAXBContext; +import jakarta.xml.bind.JAXBException; +import java.io.InputStream; +import java.util.ArrayList; +import javax.xml.stream.XMLInputFactory; +import javax.xml.stream.XMLStreamException; +import market.guess.api.LoadResult; +import market.guess.api.Result; +import market.guess.service.catalog.infrastructure.mapper.v3.EventMapperV3; +import market.guess.service.catalog.infrastructure.repository.EventRepository; +import market.guess.service.catalog.model.v3.GMEvent; +import market.guess.service.catalog.model.v3.GuessMarket; + +public final class XMLLoaderV3 { + private final JAXBContext contextV3; + private final XMLInputFactory xmlInput; + private final EventRepository eventRepository; + private final EventMapperV3 mapperV3; + private final XMLValidatorV3 validatorV3; + + public XMLLoaderV3( + EventRepository eventRepository, EventMapperV3 mapperV3, XMLValidatorV3 validatorV3) { + this.eventRepository = eventRepository; + this.mapperV3 = mapperV3; + this.validatorV3 = validatorV3; + try { + this.contextV3 = JAXBContext.newInstance(GuessMarket.class); + } catch (JAXBException e) { + throw new IllegalStateException("Failed to initialize JAXB context: " + e.getMessage(), e); + } + this.xmlInput = XMLInputFactory.newFactory(); + xmlInput.setProperty(XMLInputFactory.SUPPORT_DTD, false); + xmlInput.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, false); + } + + public synchronized Result load(InputStream in, String source, String uploader) { + if (in == null) { + return Result.error("INVALID_INPUT", "No file content was provided."); + } + if (uploader == null || uploader.isBlank()) { + return Result.error("INVALID_UPLOADER", "An upload must come from a logged-in user."); + } + + GuessMarket seed; + try { + var reader = xmlInput.createXMLStreamReader(in); + try { + seed = (GuessMarket) contextV3.createUnmarshaller().unmarshal(reader); + } finally { + reader.close(); + } + } catch (JAXBException e) { + var cause = + e.getLinkedException() != null ? e.getLinkedException().getMessage() : e.getMessage(); + return Result.error( + "XML_PARSE_ERROR", + "The XML file is malformed or invalid: " + (cause != null ? cause : e.getMessage())); + } catch (XMLStreamException e) { + return Result.error("XML_PARSE_ERROR", "The XML file is malformed: " + e.getMessage()); + } + + var validation = validatorV3.validate(seed, eventRepository); + if (!validation.isSuccess()) { + return Result.error(validation.getMessage(), validation.getDetails()); + } + + var nextId = eventRepository.getAll().size() + 1; + var mapped = new ArrayList(); + for (GMEvent e : seed.getGMEvents().getGMEvent()) { + mapped.add(mapperV3.toDomain(e, nextId++, uploader.trim())); + } + mapped.forEach(eventRepository::add); + + return Result.ok(new LoadResult(source, mapped.size())); + } +} -- cgit v1.2.3